#141680: "incorrect score display"
De què tracta aquest informe?
Què ha passat? Si us plau, selecciona a sota
Què ha passat? Si us plau, selecciona a sota
Si us plau, comprova si ja existeix un informe sobre el mateix tema
En cas afirmatiu, si us plau VOTA per aquest informe. Els informes amb més vots tenen PRIORITAT!
| # | Status | Votes | Game | Type | Title | Last update |
|---|
Descripció detallada
-
• Si us plau, copia i enganxa el missatge d'error que veus a la pantalla, si és que n'hi ha algun.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Si us plau, què volies fer, què vas fer i que va succeir
• Quin és el meu navegador?
opera
-
• Si us plau, copieu/enganxeu el text mostrat en anglès en comptes del teu idioma. If you have a screenshot of this bug (good practice), you can use a picture hosting service of your choice (snipboard.io for example) to upload it and copy/paste the link here. És aquest text disponible al sistema de traducció? Si és així, ha sigut traduït fa més de 24 hores?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Quin és el meu navegador?
opera
-
• Si us plau, expliqueu el vostre suggeriment de manera precisa i concisa, per que sigui el més fàcil d'entendre possible.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Quin és el meu navegador?
opera
-
• Què es mostrava a la pantalla quan estaves bloquejat (pantalla en blanc? Part de la interfície del joc? Missatge d'error?)
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Quin és el meu navegador?
opera
-
• Quina part de les regles no s'han respectat per l'adaptació de BGA
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• És visible la violació de les normes durant la repetició de la partida? Si es així, en quin número de moviment?
• Quin és el meu navegador?
opera
-
• Quina va ser l'acció del joc que volies fer?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Què intentes fer per dur a terme aquesta acció del joc?
-
• Què va passar quan ho vas intentar fer (missatge d'error, missatge de la barra d'estat de la partida, ...)?
• Quin és el meu navegador?
opera
-
• A quina fase del joc va passar l'error (quina era la ordre en curs)?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Què va passar quan vas intentar dur a terme l'acció del joc (missatge d'error, missatge de la barra d'estat del joc, ...)?
• Quin és el meu navegador?
opera
-
• Si us plau, descriviu el problema de visualització. If you have a screenshot of this bug (good practice), you can use a picture hosting service of your choice (snipboard.io for example) to upload it and copy/paste the link here.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Quin és el meu navegador?
opera
-
• Si us plau, copieu/enganxeu el text mostrat en anglès en comptes del teu idioma. If you have a screenshot of this bug (good practice), you can use a picture hosting service of your choice (snipboard.io for example) to upload it and copy/paste the link here. És aquest text disponible al sistema de traducció? Si és així, ha sigut traduït fa més de 24 hores?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Quin és el meu navegador?
opera
-
• Si us plau, expliqueu el vostre suggeriment de manera precisa i concisa, per que sigui el més fàcil d'entendre possible.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Quin és el meu navegador?
opera
Historial de denúncies
- From the location cards image, it looks like happens in night phase.
- The left lane location number is set to `2` even though there isn't any card that modifies the number (it should be 1 in that case).
- The center lane location number is set to `3` even though `Maat` is presented (it should be 5 in that case).
Possibly there are two issues.
1. Plotting number is wrongly done in some case?
2. Day / Night state is wrongly set in some case? (while restoring game?)
1. This happened in 2nd round.
2. After browser refresh, it displayed correct result (this means the game state is restored correctly).
3. Replay from previous round did not reproduced the bug.
4. Wrongly displayed result was different from previous round result. i.e. This is not a bug that displays previous round result.
This needs further investigation.
github.com/giantroach/sunrisesunset/blob/v0.4/bga_src/backend/sunrisesunset.game.php#L1092
1. `'i18n' => ['lane'],` makes `lane` arg to be translated.
en.doc.boardgamearena.com/Translations
2. This `lane` arg is referred in client side code. And that expects one of `left`, `right` or `center`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L304
If a player is playing in other than English language (in my case Japanese), this logic won't work.
Though, it is weird that it displayed win / lose / tie on screen in this case.
1. scoreData.result is reset every `newRound`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L50
2. Displaying result logic explicitly checking the scoreData.result value without fallback.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/state.ts#L825-L841
So I suspect this is not yet everything.
1. As I mentioned above, lane translation is one of the cause of this issue. Due to this bug, win / lose / draw is usually not be displayed when you are playing the game with other than English language.
2. When you restore the game state, score data from previous round will be restored. Current game logic is expecting to have those score data to be emptied every new round. So this is an unexpected state.
3. When score data isn't empty and when game state goes endRound, it immediately proceeds to display the game result, without waiting any other process.
4. Changing of state does not have any delay, unlike the notification handler that has max 1sec of intentional delay (to let player observe what is happening), so this causes displaying prev round score data mixed with current round data!
1. and 2. should be fixed. Do not restore the score data unless it is endRound state.
Translation of lane name is partly disabled due to this fix and currently it is inconsistent.
This translation issue will be dealt separately.
Afegeix quelcom a aquest report
- Un altre ID de partida / ID de moviment
- Prémer F5 ha ajudat a arreglar el problema?
- El problema apareix diversos cops? Cada cop? a l'atzar?
- If you have a screenshot of this bug (good practice), you can use a picture hosting service of your choice (snipboard.io for example) to upload it and copy/paste the link here.
